Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opentelemetry-exporter-jaeger, ... to 1.11.0 #137

Conversation

scala-steward
Copy link
Contributor

Updates

from 1.10.1 to 1.11.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "io.opentelemetry" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@catostrophe
Copy link
Member

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Feb 5, 2022

rebase

✅ Branch has been successfully rebased

@janstenpickle janstenpickle force-pushed the update/opentelemetry-exporter-jaeger-1.11.0 branch from b944b79 to 9958dc5 Compare February 5, 2022 11:18
@catostrophe
Copy link
Member

@brendanmaguire FYI
opentelemetry-java deprecated the .setChannel method in *GrpcSpanExporters, see open-telemetry/opentelemetry-java#4116

A few months ago you added extra configuration for channels. I think we need to be aligned with opentelemetry-java and switch to .setEndpoint. Will this affect your use cases?

@catostrophe catostrophe force-pushed the update/opentelemetry-exporter-jaeger-1.11.0 branch from edcb7cc to b29350d Compare February 5, 2022 13:12
@catostrophe
Copy link
Member

@brendanmaguire please review the changes I propose

@catostrophe
Copy link
Member

@brendanmaguire hi, any objections? We're going to cut a new release soon. So I'd like to merge it.

@brendanmaguire
Copy link
Contributor

@catostrophe , Makes sense to me. If there are any issues I'll let the underlying library owners know. Thanks for the heads up 🙂

@catostrophe catostrophe merged commit 88b7674 into trace4cats:master Feb 18, 2022
@brendanmaguire
Copy link
Contributor

@catostrophe , turns out a change is needed 🙂 Just tried updating the library now and ran into an issue. #160 is the related PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants