Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 #1422

Merged
merged 47 commits into from
Oct 7, 2020
Merged

Vue 3 #1422

merged 47 commits into from
Oct 7, 2020

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Sep 21, 2020

進捗は #1295 で管理

  • 一部のストアをprovide/injectに書き換え
  • websocketの受け取りを一括ではなくそれぞれのストア側で受け取るように
  • MessageInput.vueとかMessageEditor.vueもprovide/injectに書き換え

この三つは別のPRで行う


あとはteleport先がteleportのマウント時に常に存在するようにしてvue-textarea-autosizevue-slider-componentが動けば動くと思う
v-click-outsideは動くかわかんないけど~~~~なんとなく動きそうな気もする~~~~動かない

最後のWIPっていうコミットは動くようにするために無理に直しているとこなので後で変更する


vue-slider-componentだけ動かないけどほかは動くようになった
ちょこちょこバグあるけど大体動く

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #1422 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1422      +/-   ##
==========================================
- Coverage   33.93%   33.90%   -0.03%     
==========================================
  Files         145      145              
  Lines        3239     3230       -9     
  Branches      457      458       +1     
==========================================
- Hits         1099     1095       -4     
+ Misses       2140     2135       -5     
Impacted Files Coverage Δ
src/store/ui/fileInput/mutations.ts 16.66% <0.00%> (-6.42%) ⬇️
src/store/entities/mutations.ts 24.32% <0.00%> (-2.71%) ⬇️
src/store/domain/mutations.ts 8.33% <0.00%> (-1.88%) ⬇️
src/store/domain/messagesView/mutations.ts 7.01% <0.00%> (-1.61%) ⬇️
src/store/domain/me/mutations.ts 13.79% <0.00%> (-1.47%) ⬇️
src/store/index.ts 94.73% <0.00%> (-0.72%) ⬇️
src/store/app/rtc/mutations.ts 3.73% <0.00%> (-0.72%) ⬇️
src/store/ui/modal/actions.ts 11.11% <0.00%> (+1.11%) ⬆️
src/router/index.ts 77.77% <0.00%> (+14.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 623c02f...3559319. Read the comment docs.

@sapphi-red sapphi-red force-pushed the feat/vue-3 branch 5 times, most recently from 255154f to 85e9ca0 Compare September 24, 2020 16:14
@sapphi-red sapphi-red force-pushed the feat/vue-3 branch 4 times, most recently from e4d509b to 7c0246f Compare September 24, 2020 19:28
> [Vue warn]: setup() return property "$img" should not start with "$" or "_" which are reserved prefixes for Vue internals.
…nt but could not be automatically inherited

> [Vue warn]: Extraneous non-props attributes (class, style) were passed to component but could not be automatically inherited because component renders fragment or text root nodes.
componentから発火されるclickイベントとnativeなelementから発火されるclickイベントの見分けがつかない
@sapphi-red sapphi-red marked this pull request as ready for review September 25, 2020 10:43
Copy link
Member

@spaspa spaspa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

みました

.eslintrc.js Show resolved Hide resolved
src/App.vue Show resolved Hide resolved
src/components/Authenticate/ConsentForm/ConsentForm.vue Outdated Show resolved Hide resolved
src/bool-attr.ts Show resolved Hide resolved
src/components/UI/VirtualScroller.vue Outdated Show resolved Hide resolved
src/store/ui/modal/actions.ts Outdated Show resolved Hide resolved
src/types/shims-bool-attr.d.ts Show resolved Hide resolved
src/views/Auth.vue Outdated Show resolved Hide resolved
@sapphi-red sapphi-red mentioned this pull request Oct 7, 2020
23 tasks
Copy link
Member

@spaspa spaspa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!お疲れ様でした!!!

@sapphi-red sapphi-red merged commit fe424cf into master Oct 7, 2020
@sapphi-red sapphi-red deleted the feat/vue-3 branch October 7, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants