-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3 #1422
Vue 3 #1422
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1422 +/- ##
==========================================
- Coverage 33.93% 33.90% -0.03%
==========================================
Files 145 145
Lines 3239 3230 -9
Branches 457 458 +1
==========================================
- Hits 1099 1095 -4
+ Misses 2140 2135 -5
Continue to review full report at Codecov.
|
90e3f1d
to
3ae8aa2
Compare
255154f
to
85e9ca0
Compare
e4d509b
to
7c0246f
Compare
> [Vue warn]: setup() return property "$img" should not start with "$" or "_" which are reserved prefixes for Vue internals.
…nt but could not be automatically inherited > [Vue warn]: Extraneous non-props attributes (class, style) were passed to component but could not be automatically inherited because component renders fragment or text root nodes.
componentから発火されるclickイベントとnativeなelementから発火されるclickイベントの見分けがつかない
eaaf265
to
0497310
Compare
4a4ce8a
to
02250a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
みました
src/components/Main/MainView/MainViewSidebar/SidebarContentContainerLink.vue
Outdated
Show resolved
Hide resolved
src/components/Main/MainView/ChannelSidebar/ChannelSidebarPinned.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!お疲れ様でした!!!
進捗は #1295 で管理
この三つは別のPRで行う
あとはteleport先がteleportのマウント時に常に存在するようにしてvue-textarea-autosize
とvue-slider-component
が動けば動くと思うv-click-outside
は動くかわかんないけど~~~~なんとなく動きそうな気もする~~~~動かない最後のWIPっていうコミットは動くようにするために無理に直しているとこなので後で変更するvue-slider-component
だけ動かないけどほかは動くようになったちょこちょこバグあるけど大体動く