Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feet/bulk group api #2484
base: master
Are you sure you want to change the base?
Feet/bulk group api #2484
Changes from 8 commits
508712e
a20133f
6bbea17
47b2186
3c0cbbc
536d689
5a8be02
8dc4202
4dbd441
e1361e7
885cc34
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
何らかの不具合があった時のために↓の様にエラーハンドリングあった方が良さそうです。OnConflictがあるので、既にグループに居るユーザーを追加しようとしてもエラーで止まることはないです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RemoveUserFromGroup
にevent.UserGroupMemberRemoved
があるので、RemoveUsersFromGroup
でもevent.UserGroupMemberRemoved
するべきですね。各ユーザーの削除を追跡して、それに基づいてイベントを発行する必要があってちょっと大変。
でユーザー一覧を消す前に取得して、削除に成功したら取得したそれぞれのユーザーに対してイベントの発行
をすれば良さそう。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ちょっとネストが深いので、↓のように早期リターンをしたほうが読みやすいかな~と思ったのですが、好みの範疇だと思うのでどちらでもokです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RemoveUserGroupMemberで全てのユーザーがグループから削除される挙動は予期されないと思うので、ここは消した方が良さそう。