Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ready_cache: just use pin_project for Pending #667

Merged
merged 3 commits into from
Jun 17, 2022
Merged

ready_cache: just use pin_project for Pending #667

merged 3 commits into from
Jun 17, 2022

Commits on Jun 16, 2022

  1. ready_cache: just use pin_project for Pending 

    This gets rid of the `Unpin` impl with the weird comment on it.

Alternatively, we could just put a `S: Unpin` bound on `Pending`, but
this changes the public API to require that the service type is `Unpin`.
In practice, it will be, but we could also just avoid the trait bound.

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    44eb6e7 View commit details
    Browse the repository at this point in the history

  2. whoops i pushed the wrong change 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    c38600c View commit details
    Browse the repository at this point in the history

  3. fix optional deps 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    996c880 View commit details
    Browse the repository at this point in the history