This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
fix: many #5
Merged
fix: many #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toutpt
commented
Mar 9, 2021
| }, { port: 3000 }); | ||
|
|
||
| if (options.help) { | ||
| if (options.help || !options.har) { |
There was a problem hiding this comment.
./express.js -h
har-express/express.js:26
if (options.help) {
^
TypeError: Cannot read property 'help' of undefined
toutpt
commented
Mar 9, 2021
| @@ -92,7 +92,7 @@ function filter(HAR, req, options=DEFAULT_OPTIONS) { | |||
| let results = entries; | |||
| // first lets filter on query params | |||
| const withSameQueryString = entries.filter(e => { | |||
| return e.request.queryString.every(qs => req.param(qs.name) === qs.value); | |||
| return e.request.queryString.every(qs => req.params[qs.name] === qs.value); | |||
There was a problem hiding this comment.
fix
express deprecated req.param(name): Use req.params, req.body, or req.query instead index.js:95:58
|
Thanks for fixing these issues so quickly! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @trentrand for the review.
All Issues:
Bonus: npm upgrade deps