-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP / [front] feat: add pages Top Videos, For You and Search #1984
Draft
GresilleSiffle
wants to merge
85
commits into
main
Choose a base branch
from
1983-new_reco_pages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DefaultFiltersFeedForYou
…esolUserSettingsForm.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issues #1983
Description
back end
The back end has a new set of settings to allow the users to configure the feeds For you and Top items. The legacy settings starting with
recommendations__
are kept to not break the old versions of the browser extension.browser extension
The browser extension doesn't rely any more on the tournesol.app local storage to set the recommendations languages for anonymous users. The legacy strategy is now fully replaced by the usage of the extension local settings for anonymous users and by the "online" settings for logged-in users.
to-do
feed - for you
feed_foryou__languages
feed_foryou__date
feed_foryou__unsafe
feed_foryou__exclude_compared_entities
recommendations__
tofeed_foryou__
defaultFiltersFeedForYou
feed_foryou__languages
feed - top videos
feed_topitems__languages
feed_topitems__languages
defaultFiltersFeedTopItems
search
recommendations
recommendations__
settings to not break older versions of the extension*/recommendations
URLpresidentielle2022
)presidentielle2022
and remove the page collective recommendationsPWA
preview
page - Preferences
create a generic field for the setting upload dateclean-up:
getRecommendationPageName
? no, still used by the personal recommendations pagegetDefaultRecommendationsSearchParams
Next steps
Checklist