Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new album options added to stop errors when adding album #144

Merged

Conversation

marksie1988
Copy link
Collaborator

Description

New options were added to the lidarr API at some point which stopped adding albums from working as expected. This change adds the new options and removes one that is no longer required.

Related issues

fixes #143

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI / Tests update
  • Documentation update

How has this been tested

  • I have added new tests where required
  • I have run nox -s tests locally and passed
  • I have tested this feature in a python script

@marksie1988 marksie1988 added the type/bug Something isn't working label Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #144 (4e6cfcd) into master (dff0ab5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4e6cfcd differs from pull request most recent head 73afc50. Consider uploading reports for the commit 73afc50 to get more accurate results

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   93.35%   93.36%           
=======================================
  Files          15       15           
  Lines        1039     1040    +1     
=======================================
+ Hits          970      971    +1     
  Misses         69       69           
Impacted Files Coverage Δ
pyarr/lidarr.py 90.86% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marksie1988 marksie1988 merged commit 4ff6086 into totaldebug:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lidarr - add_album throws errors
1 participant