-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make job fail when partial tasks' pre-dependent tasks finished and exceeds the waiting timeout #621
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -334,4 +334,23 @@ public static String getContainerDockerMountKey() { | |
|
||
public static final String TB_GPUS = TB_JOB_PREFIX + "gpus"; | ||
public static final int DEFAULT_TB_GPUS = 0; | ||
|
||
/** | ||
* Introduce the group dependency waiting time(sec), like as follows: | ||
* tony.application.group.a = worker,chief | ||
* tony.application.group.b = evaluator | ||
* | ||
* tony.application.dependency.b.timeout.after.a = 3600 | ||
*/ | ||
public static final String GROUP_REGEX = TONY_APPLICATION_PREFIX + "group\\.([A-Za-z]+)$"; | ||
public static final String GROUP_DEPEND_TIMEOUT_REGEX = | ||
TONY_APPLICATION_PREFIX + "dependency\\.([A-Za-z]+)\\.timeout\\.after\\.([A-Za-z]+)$"; | ||
Comment on lines
+344
to
+346
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also add some unit tests for these regex.. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Got it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It has been tested in |
||
|
||
public static String getGroupKey(String groupName) { | ||
return String.format(TONY_APPLICATION_PREFIX + "group.%s", groupName); | ||
} | ||
|
||
public static String getGroupDependentKey(String grp, String dependentGrp) { | ||
return String.format(TONY_APPLICATION_PREFIX + "dependency.%s.timeout.after.%s", grp, dependentGrp); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does
b
have to be a group? I thinkworker.timeout.after.a
also works from conversations. Can you clarify here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mistake for code comment, i will fix it.
And
tony.application.dependency.evaluator.timeout.after.a
is best practise.