Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable status when dependency times out #641

Closed
oliverhu opened this issue Feb 5, 2022 · 2 comments · Fixed by #642
Closed

Configurable status when dependency times out #641

oliverhu opened this issue Feb 5, 2022 · 2 comments · Fixed by #642

Comments

@oliverhu
Copy link
Member

oliverhu commented Feb 5, 2022

Follow up from #621 .
In some of the cases, we don't want to fail the whole job even though a dependency times out. For example, if chief succeeded and there is a worker hanging for 1 hour, users can configure the job to still pass.

tony.application.group.A = worker,chief
tony.application.dependency.evaluator.timeout.after.A = 3600
tony.application.dependency.evaluator.timeout.after.A.ignored = true

@zuston thoughts?
@zuston
Copy link
Member

zuston commented Feb 5, 2022

Make sense

@zuston zuston mentioned this issue Feb 5, 2022
Merged
@zuston zuston linked a pull request Feb 5, 2022 that will close this issue
Configurable status when dependency times out #642
Merged
zuston added a commit that referenced this issue Feb 6, 2022
@zuston
Configurable status when dependency times out (#642)
416019c 
Introducing the new config of `tony.application.dependency.[X].timeout.after.[GROUP].ignored = true` to solve the #641. When specifying the above conf, it will make this task type untracked.
@zuston
Copy link
Member

zuston commented Feb 6, 2022

Updated version on #643 @oliverhu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configurable status when dependency times out zuston/TonY
2 participants
@oliverhu @zuston