-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multilevel groupby #69
base: main
Are you sure you want to change the base?
Conversation
Excellent, thanks again Julien. This is something that I've been putting off for a while! @jraffa, if possible, please could you take a look at this change from a user perspective? Two things in particular that we need to think about are (1) if/how p-values should be reported for multilevel grouping (2) how |
Couple of comments:
a. Columnwise: denominator for first column for ICU variable is 110+50+205+103=468 (as in the table header.) Columnwise is probably a good default. Should probably be explained somewhere in the docs.
a. If factor one has n levels, and factor two has m levels: Have the default treat crosses of the n and m levels to do a n*m-1 degree of freedom test (as currently done). I think type b. is probably more intuitive to someone who hasn't read the docs. But I could see the other argument on the other side as well. Let me know if I have confused you. |
9ff9874
to
1db34db
Compare
6f62620
to
fabcd16
Compare
Hi,
This code closes #18, adding support for multilevel groupby. It also fixes a bug where in some cases descriptives for categorical and continuous variables were being shown in separate columns if a dtype category groupby variable was used.
Best,
Julien