-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toml 0.6.0 no longer allows deserializing a struct with an explicit lifetime #490
Comments
This was an intentional change as by using |
Got it. Is there a documentation change that can be made to make that explicit? I looked through the changelog but nothing stood out as the cause for this which is why I ended up raising this issue. |
The changelog was updated. |
So why does toml_edit convert everything to String? |
In theory, we could add an internal In theory, we could also parse into a As an alternative to |
It seems quite surprising to me to just throw away the ability to zero-copy/low-allocation deserialization when that is one of the main benefits usually offered by serde integrations. Offering a |
Do you have a use case where the benefits of zero-copy / low allocation deserialization is important? Assuming its performance driven, what is the actual performance before/after this and what is your performance target and why is that performance target set? |
I don't currently have such a use case. My usage of toml that prompted these questions was for Askama's configuration file. |
For what is worth, I'd like to point out that |
The difference between |
I've raised #489 as a minimal repro within the existing test suite
The text was updated successfully, but these errors were encountered: