toml_edit doesn't properly handle quotes in strings
#128
Labels
C-bug
Category: Things not working as expected
Comments
This was referenced Aug 26, 2021
Closed
|
I tried reaching out on gitter but got no response: https://gitter.im/Marwes/combine?at=612547ac5739ab2df8b6c2ec |
This was referenced Sep 22, 2021
epage
added a commit
to epage/toml_edit
that referenced
this issue
Sep 28, 2021
This doesn't fix toml-rs#128 but it makes it clearer where we are broken. We might also get some batching string creation performance benefits. This also makes it clear why `ml_literal_string` needs to allocate. We could possibly swap out a `Cow` so only `\r\n` users see a cost.
epage
added a commit
that referenced
this issue
Sep 28, 2021
This doesn't fix #128 but it makes it clearer where we are broken. We might also get some batching string creation performance benefits. This also makes it clear why `ml_literal_string` needs to allocate. We could possibly swap out a `Cow` so only `\r\n` users see a cost.
|
Github's regex is way too loose when it closes things as fixed because you explained it wasn't fixed. Thanks for noticing! |
epage
added a commit
to epage/toml_edit
that referenced
this issue
Sep 29, 2021
Required munging the grammar so `combine` could understand, but we got it! Fixes toml-rs#128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Run
cargo test decoder_compliance -- --noignoreand you'll see a test failure for'''' test ''''which should produce' test 'but instead errors.The text was updated successfully, but these errors were encountered: