-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported versions matrix #137
Update supported versions matrix #137
Conversation
airflow-version: | ||
- '2.7.2' | ||
- '2.6.3' | ||
- '2.5.3' | ||
- '2.4.3' | ||
- '2.9.2' | ||
- '2.8.4' | ||
- '2.7.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll probably want a policy for Airflow version support.
For Python versions it's easy: We aim to support whatever dbt supports, which currently has only a >=3.8. restriction.
For Airflow, I'd say we definitely want to test against latest official minor version (2.9.x), and ideally also latest MWAA-supported version (2.8.1). Astronomer supports new Airflow versions pretty much as soon as they come out, so we are covered there already.
Any other hosted service we should consider prioritizing? If not, I'd consider just supporting 2.9 and 2.8.1 here. There is a tradeoff between as much support as possible and CI times and dependency resolution. So, I'd try to keep the number of "tested" supported versions as small as possible, to avoid the test matrix exploding too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to support Airflow 2.7.x as it is still in use by Cloud Composer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind mentioning in the docs?
We mention testing against latest MWAA version in https://github.com/tomasfarias/airflow-dbt-python/blob/master/docs/development.rst?plain=1#L40, so we could extend that with a few extra words: "... latest version available in AWS MWAA and in Cloud Composer" + a link to the Cloud composer docs.
dbt-version: | ||
- 1.8 | ||
- 1.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 latest dbt versions is a fair policy 👍
Tried testing locally, but it seems like some new flags need to be supported starting with dbt 1.7, and flags_dict["PARTIAL_PARSE_FILE_DIFF"] = self.partial_parse_file_diff
flags_dict["USE_EXPERIMENTAL_PARSER"] = self.use_experimental_parser
flags_dict["CACHE_SELECTED_ONLY"] = self.cache_selected_only
flags_dict["PARTIAL_PARSE_FILE_PATH"] = self.partial_parse_file_path (And also the corresponding class attributes) As well as dropping Dag tests ( |
Sorry, I created this pr prematurely. |
No problem! Happy to review next week and get this released. |
4464209
to
2c4fc21
Compare
2c4fc21
to
0cab907
Compare
efb23d7
to
983b577
Compare
983b577
to
43c1f47
Compare
@@ -66,6 +66,12 @@ Add *airflow-dbt-python* to your `requirements.txt` file and edit your Airflow e | |||
|
|||
Read the [documentation](https://airflow-dbt-python.readthedocs.io/en/latest/getting_started.html#installing-in-mwaa) for more a more detailed AWS MWAA installation breakdown. | |||
|
|||
## In GCP Cloud Composer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Great updates!
Will release shortly. Thanks for the great work @millin |
fixes #134
fixes #135