Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Since update to 2.1.2 - CPU temperature entity is missing #243

Open
j0hnby opened this issue Sep 5, 2022 · 10 comments
Open

[Bug] Since update to 2.1.2 - CPU temperature entity is missing #243

j0hnby opened this issue Sep 5, 2022 · 10 comments
Labels
bug Something isn't working planned To be implemented in future release

Comments

@j0hnby
Copy link

j0hnby commented Sep 5, 2022

Describe the issue

Since updating to V 2.1.2, the CPU temperature entity isn't present for my router in homeassistant

How to reproduce the issue

Use previous version, update to v2.1.2, it's gone.

Expected behavior

CPU temperature measurement is present

Screenshots

image

Software versions

  • Home Assistant version:
  • Mikrotik Router integration version:
  • Mikrotik Hardware:
  • RouterOS version:

Home Assistant 2022.8.7
Supervisor 2022.08.5
Operating System 8.5
Frontend 20220802.0 - latest
Mikrotik Router integration version: v2.1.2
Mikrotik Hardware: CRS326-24G-2S+
RouterOS Version: 7.2rc4

@j0hnby j0hnby added the bug Something isn't working label Sep 5, 2022
@j0hnby j0hnby changed the title Since update to 2.1.2 - CPU temperature is missing as[Bug] Since update to 2.1.2 - CPU temperature entity is missing [Bug] Sep 5, 2022
@j0hnby
Copy link
Author

j0hnby commented Sep 5, 2022

apologies - I mistakenly pressed enter and it submitted without any details!! Updating now

@tomaae tomaae changed the title Since update to 2.1.2 - CPU temperature entity is missing [Bug] [Bug] Since update to 2.1.2 - CPU temperature entity is missing Sep 5, 2022
@tomaae
Copy link
Owner

tomaae commented Sep 5, 2022

I will need debugs to see what is going on there.

@j0hnby
Copy link
Author

j0hnby commented Sep 5, 2022

home-assistant.log
Sorry - attached, thought I had done that earlier!

@tomaae
Copy link
Owner

tomaae commented Sep 5, 2022

this will be the reason:
2022-09-05 19:00:26.437 WARNING (SyncWorker_6) [custom_components.mikrotik_router.mikrotik_controller] Mikrotik 192.168.0.1 user hass does not have sufficient access rights. Integration functionality will be limited.
Health sensors are not available without write permissions for some reason.

See https://github.com/tomaae/homeassistant-mikrotik_router#setup-integration for both full and limited requirements.

I see you are using 7.5rc1, so they may have finally fixed their issue with health permission requirements there, but based on my experience with mikrotik beta/rc, I wont be updating for 7.5 support until full release. They change significant things even durring rc

@j0hnby
Copy link
Author

j0hnby commented Sep 5, 2022

Up until the update to 2.1.2, the api user didn't have write and showed the temperature. This afternoon I changed it to write to test access as found that detail in the docs while doing troubleshooting. Still no temperature measurement. I changed it back to read then.

image

Those logs were gathered with the read access, attached are ones with write instead
home-assistant (with write access).log

@tomaae
Copy link
Owner

tomaae commented Sep 5, 2022

you are missing "policy". but it may be possible that I have forgot to adjust required permissions for system health.

tomaae added a commit that referenced this issue Sep 6, 2022
@tomaae
Copy link
Owner

tomaae commented Sep 6, 2022

image
this could be also related

@j0hnby
Copy link
Author

j0hnby commented Sep 6, 2022

Adding in "Policy" as the user permission brought it back - what a strange set to requirements from MKT to get env data!
image

Thanks for your help!

@katiuskt
Copy link

katiuskt commented Sep 12, 2022

Same problem here: no temperature sensor after 2.1.2 upgrade

Device: RB4011iGS+5HacQ2HnD
User belongs to a group with these permissions. In particular, policy and write ones are enabled:
image

Temperature information was reported prior 2.1.2 upgrade.
Reverted back to 2.1.1 it works again (under same 7.5 firmware release and with the same permissions).

Taking a look at 2.1.2 vs 2.1.1 diff I just realized that I didn't have "reboot" policy allowed:
image

It was properly mentioned at https://github.com/tomaae/homeassistant-mikrotik_router#setup-integration so it is clearly my fault!!

But, just one question if I may: is it really necessary to have "reboot" policy to get /system/health information? It was working on 2.1.1 release without it so I just wondering.

I'll prefer not to enable "reboot" policy only for health information if it is possible.

@tomaae
Copy link
Owner

tomaae commented Sep 12, 2022

no, thats why I'm leaving this open. I will need to crosscheck some permissions as I may have copied some without adjusting them.
policy should not be technically needed there as well. but I will test it all manually on several devices before changing it.
system health is really messed up on mikrotik side when it comes to persmissions.

@github-actions github-actions bot added the stale label Sep 27, 2022
Repository owner deleted a comment from github-actions bot Sep 27, 2022
@tomaae tomaae removed the stale label Sep 27, 2022
@github-actions github-actions bot added the stale label Oct 12, 2022
@tomaae tomaae added planned To be implemented in future release and removed stale labels Oct 12, 2022
Repository owner deleted a comment from github-actions bot Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working planned To be implemented in future release
Projects
None yet
Development

No branches or pull requests

3 participants