Resolving semantic colors from arbitrary packages on android #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arazabishov
changed the title
tom-un
pushed a commit
that referenced
this pull request
Sep 1, 2020
* Add ScreenshotManagerTurboModule, but it is not called. * ... * Update AppDelegate.mm * Fix code due to facebook API rename * Update AppDelegate.mm * [Pods] Expose boost headers to consumer of RCT-Folly (#1) * Update AppDelegate.mm * ScreenshotManagerTurboModule gets called * reject the promise in takeScreenshot * ... * Put TurboModuleRegistry.get call at the right place * ... * Successfully took the screenshot * Remove unnecessary code * Fix code review comments * Fix code review comments * ... * Fix code review comments * Fix build break * Fix build break * Fix build break * Update NativeScreenshotManager.js * Fix build break * Fix yarn lint errors Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for semantic colors on android for arbitrary packages, as well as various ways to references colors. To showcase the change more color reference examples were added to the
PlatformColorExample.