subscriber: fix unused method warnings for Extensions
#1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there are some `pub(crate)` methods on the `Extensions`, `ExtensionsMut`, and `ExtensionsInner` types that are only used when the "registry" feature is enabled. However, the _types_ exist when the "std" feature flag is enabled, so those methods produce unused method warnings. This commit adds `#[cfg(feature = "registry")]` to those methods, fixing the warning.
davidbarsky
approved these changes
Oct 25, 2021
hawkw
added a commit
that referenced
this pull request
Oct 25, 2021
## Motivation Currently, there are some `pub(crate)` methods on the `Extensions`, `ExtensionsMut`, and `ExtensionsInner` types that are only used when the "registry" feature is enabled. However, the _types_ exist when the "std" feature flag is enabled, so those methods produce unused method warnings. ## Solution This commit adds `#[cfg(feature = "registry")]` to those methods, fixing the warning.
hawkw
added a commit
that referenced
this pull request
Oct 25, 2021
# 0.3.1 (Oct 25, 2021) This release fixes a few issues related to feature flagging. ### Fixed - **time**: Compilation error when enabling the "time" feature flag without also enabling the "local-time" feature flag ([#1685]) - **registry**: Unused method warnings when the "std" feature is enabled but the "registry" feature is disabled ([#1686]) [#1685]: #1685 [#1686]: #1686
hawkw
added a commit
that referenced
this pull request
Oct 25, 2021
# 0.3.1 (Oct 25, 2021) This release fixes a few issues related to feature flagging. ### Fixed - **time**: Compilation error when enabling the "time" feature flag without also enabling the "local-time" feature flag ([#1685]) - **registry**: Unused method warnings when the "std" feature is enabled but the "registry" feature is disabled ([#1686]) [#1685]: #1685 [#1686]: #1686
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.3.1 (Oct 25, 2021) This release fixes a few issues related to feature flagging. ### Fixed - **time**: Compilation error when enabling the "time" feature flag without also enabling the "local-time" feature flag ([tokio-rs#1685]) - **registry**: Unused method warnings when the "std" feature is enabled but the "registry" feature is disabled ([tokio-rs#1686]) [tokio-rs#1685]: tokio-rs#1685 [tokio-rs#1686]: tokio-rs#1686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, there are some
pub(crate)methods on theExtensions,ExtensionsMut, andExtensionsInnertypes that are only used when the"registry" feature is enabled. However, the types exist when the "std"
feature flag is enabled, so those methods produce unused method
warnings.
Solution
This commit adds
#[cfg(feature = "registry")]to those methods, fixingthe warning.