Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move prost to a subdirectory #1033

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

gibbz00
Copy link
Contributor

@gibbz00 gibbz00 commented Apr 21, 2024

Removes the need to always specify append --workspace in the common cargo commands.

rust-analyser seems to get confused and locks the workspace longer than needed under the previous structure. (Lots of Blocking waiting for file lock on build directory waiting.) Unable to find an issue mentioning this.

Goals it to then make repo to more easily managed. Examples:

  • Consolidate crate package metadata, dependency versions and clippy lints in the workspace Cargo.toml

  • Placing all crates in a crates/ for automatic workspace member inclucion.

Removes the need to always specify append `--workspace` in the common
cargo commands.

`rust-analyser` seems to get confused and locks the workspace longer
than needed under the previous structure. (Lots of `Blocking waiting
for file lock on build directory` waiting.) Unable to find an issue
mentioning this.

Goals it to then make repo to more easily managed. Examples:

* Consolidate crate package metadata, dependency versions and clippy
lints in the workspace `Cargo.toml`

* Placing all crates in a `crates/` for automatic workspace member
inclucion.
@caspermeijn caspermeijn changed the title chore: separate prost Cargo.toml workspace and crate declaration chore: Move prost to a subdirectory Apr 22, 2024
@caspermeijn caspermeijn added this pull request to the merge queue Apr 22, 2024
Merged via the queue into tokio-rs:master with commit 215ae16 Apr 22, 2024
13 checks passed
caspermeijn added a commit to caspermeijn/prost that referenced this pull request May 10, 2024
The release scripts were broken by moving `prost` crate into a separated directory in tokio-rs#1033.

fixes tokio-rs#1054
caspermeijn added a commit to caspermeijn/prost that referenced this pull request May 17, 2024
The release scripts were broken by moving `prost` crate into a separated directory in tokio-rs#1033.

fixes tokio-rs#1054
caspermeijn added a commit to caspermeijn/prost that referenced this pull request May 20, 2024
The release scripts were broken by moving `prost` crate into a separated directory in tokio-rs#1033.

fixes tokio-rs#1054
caspermeijn added a commit to caspermeijn/prost that referenced this pull request May 21, 2024
The release scripts were broken by moving `prost` crate into a separated directory in tokio-rs#1033.

fixes tokio-rs#1054
caspermeijn added a commit to caspermeijn/prost that referenced this pull request May 23, 2024
The release scripts were broken by moving `prost` crate into a separated directory in tokio-rs#1033.

fixes tokio-rs#1054
github-merge-queue bot pushed a commit that referenced this pull request May 24, 2024
The release scripts were broken by moving `prost` crate into a separated directory in #1033.

fixes #1054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants