Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ptr_map special casing for miri (#565) #630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shahn
Copy link
Contributor

@shahn shahn commented Sep 21, 2023

Since Rust 1.65, which introduced LLVM 15, codegen for both versions of ptr_map is the same. The release happened in Nov 2022, which should mean the majority of users have upgraded.

Since Rust 1.65, which introduced LLVM 15, codegen for both versions of
ptr_map is the same. The release happened in Nov 2022, which should mean
the majority of users have upgraded.
@seanmonstar
Copy link
Member

I wouldn't make this change until the MSRV was forced passed that version. And since this is just for tests, there isn't enough of a reason to force it.

@shahn
Copy link
Contributor Author

shahn commented Sep 22, 2023

Bumping MSRV for sure is not warranted for this change. I made this patch due to this: #565 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants