Compiler scopes and intermediate object construction rework #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the same interface than before, but removes the unpacking overhead.
1. Move variables and tempos into ImlParseletModel. 2. Scratch Scope2 as next scoping implementation, already compiles. 3. Unsure if this is all right and good, but its better than before.
This is almost working and the conceptual way to go, after testing several other ways and stuff. [skip ci]
Makes Tokay useable again! Nevertheless, this is only a crutch to restore the previous behavior. Further considerations are necessary to bring Compiler and Scope together optimally.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is part of #128, and restructures the Compiler to modularization and separating the Scope maintenance to something extendable and more universal.