Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build_scripts: nrf52840: bump ram size used for app #529

Merged
merged 1 commit into from
Jan 12, 2024
Merged

build_scripts: nrf52840: bump ram size used for app #529

merged 1 commit into from
Jan 12, 2024

Conversation

twilfredo
Copy link
Contributor

This allows apps that use a heap (global allocator) to allocate a larger heap pool without the linker complaining.

@twilfredo
build_scripts: nrf52: bump ram size used for app
4f7dbb6 
This allows apps that use a heap (global allocator) to
allocate a larger heap pool without the linker complaining.

Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
@twilfredo
Copy link
Contributor Author

@alistair23

@twilfredo twilfredo changed the title build_scripts: nrf52: bump ram size used for app build_scripts: nrf52840: bump ram size used for app Jan 12, 2024
lschuermann
lschuermann approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is a fine default, given that this needs to be customized anyways for running multiple libtock-rs apps (in which case, such a large RAM allocation may be undesirable).

@jrvanwhy jrvanwhy added the upkeep Indicates a PR is upkeep as defined by the code review policy. label Jan 12, 2024
@jrvanwhy jrvanwhy added this pull request to the merge queue Jan 12, 2024
Merged via the queue into tock:master with commit 334c802 Jan 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair23 alistair23 alistair23 approved these changes

@jrvanwhy jrvanwhy jrvanwhy approved these changes

@lschuermann lschuermann lschuermann approved these changes

Assignees
No one assigned
Labels
upkeep Indicates a PR is upkeep as defined by the code review policy.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twilfredo @alistair23 @jrvanwhy @lschuermann