api: adc: exists needs to handle number of channels #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair23
previously approved these changes
Aug 1, 2023
|
Linking the kernel-issue here: tock/tock#3375. Also marked that one a release blocker, such that we actually take care of that before the next release. |
This is a bug in the kernel which will be fixed in future releases but for now we enable the ADC example to work.
jrvanwhy
added
the
upkeep
jrvanwhy
reviewed
Aug 4, 2023
jrvanwhy
previously approved these changes
Aug 4, 2023
bradjc
commented
Aug 4, 2023
Kernel reports success_u32 with the number of channels.
We want exists to be a boolean, but it currently isn't in the kernel, so we hide the success_u32 in the api layer. When tock updates to change this we can remove this .and() call.
jrvanwhy
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug in the kernel which will be fixed in future releases but for now we enable the ADC example to work.