Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: buttons: fix #483

Merged
merged 1 commit into from
Aug 4, 2023
Merged

examples: buttons: fix #483

merged 1 commit into from
Aug 4, 2023

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Aug 1, 2023

Seems like maybe this wasn't updated at some point?

I did need to make the stack bigger.

ppannuto
ppannuto approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that stack size is for the formatting stuff now pulled in.

@bradjc
examples: buttons: fix
482be6f 
Seems like maybe this wasn't updated at some point?
jrvanwhy
jrvanwhy approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@jrvanwhy jrvanwhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah core::fmt uses a lot of stack in addition to using a lot of flash.

@jrvanwhy jrvanwhy added the upkeep Indicates a PR is upkeep as defined by the code review policy. label Aug 4, 2023
@jrvanwhy jrvanwhy added this pull request to the merge queue Aug 4, 2023
Merged via the queue into master with commit 83bb348 Aug 4, 2023
3 checks passed
@jrvanwhy jrvanwhy deleted the fix-buttons branch August 4, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair23 alistair23 alistair23 approved these changes

@ppannuto ppannuto ppannuto approved these changes

@jrvanwhy jrvanwhy jrvanwhy approved these changes

Assignees
No one assigned
Labels
upkeep Indicates a PR is upkeep as defined by the code review policy.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bradjc @alistair23 @ppannuto @jrvanwhy