[WIP] Add links to export codespeed charts as PNGs #227
Conversation
|
The scaling of the rendered image is currently off; the graph and axis labels are rendered larger than the axes and tick labels, causing the graph to appear truncated. |
|
Very good! So jqplot has this functionality after all. This renders properly for me, can you please paste your png? Also, the new link reads "PNG permalink". I'd put the link somewhere else closer to the graph. |
str4d
force-pushed
the
134-export-charts-as-images
branch
from
0120b40
to
d91c362
Compare
Here's the regular timeline view (data from the Zcash codespeed instance):
And the result of clicking on the PNG link:
Force-pushed to fix this; it now displays down beside the plot description in a button-like UI element. I've also pulled it over to the comparisons page plots. |
str4d
changed the title
str4d
changed the title
|
The rendering issue above is in Firefox 55.0.2 (on Ubuntu 16.0.4.3 LTS). Interestingly, I just tried using it in Chrome 60.0.3112.101 and it doesn't work at all for security reasons: Pushing another commit that works around this using an iframe. |
|
Hmm, this is also insufficient - the iframe in the new tab looks fine on Firefox but starts out with zero height in Chrome. Opening the dev console fixes the iframe height in Chrome. Also in the timeline view, the page is reset to showing the default (grid) view. |
|
Ouch, isn't there another workaround not using an iframe? |
Closes #134