Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention hybrid key exchange for split TLS ClientHello #1340

Closed
wants to merge 1 commit into from

Conversation

loganaden
Copy link

Would it be worth mentioning this specific case https://tldr.fail/, where TLS ClientHello processing is not implemented correctly ?

Would it be worth mentioning this specific case https://tldr.fail/, where TLS ClientHello processing is not implemented correctly ?
@davidben
Copy link
Contributor

davidben commented Mar 7, 2024

The case in that website is not what the bullet point is talking about. The bullet point is talking about a single TLS ClientHello spread over multiple TLS records. That's about issues like CVE-2014-3511.

The common problem with hybrids is when a single-record ClientHello does not fit in a TCP packet.

@loganaden
Copy link
Author

Thanks for point this out. I will change the PR to have a dedicate line for the tldr issue. Is that ok @davidben ?

@ekr
Copy link
Contributor

ekr commented Apr 5, 2024

This just seems like a basic failure of how the TLS stack interacts with the TCP layer. I'm not sure we need to mention it.

@loganaden
Copy link
Author

Understood @ekr . I'm closing it.

@loganaden loganaden closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants