Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errata 6136 #1355

Closed
BenSmyth opened this issue May 17, 2024 · 1 comment
Closed

Errata 6136 #1355

BenSmyth opened this issue May 17, 2024 · 1 comment

Comments

@BenSmyth
Copy link
Contributor

Errata 6136

Section 4.1.4 says:

Upon receipt of a HelloRetryRequest, the client MUST check the legacy_version, legacy_session_id_echo, cipher_suite, and legacy_compression_method as specified in Section 4.1.3

but

Section 4.1.3 defines no checks for legacy_version nor legacy_compression_method

Specifically, we have (RFC8446)

...the legacy_version field MUST be set to 0x0303...

and

legacy_compression_method: A single byte which MUST have the value 0.

neither of which are checks, whereas

A client which receives a legacy_session_id_echo field that does not match what it sent in the ClientHello MUST abort the handshake with an "illegal_parameter" alert.

and

A client which receives a cipher suite that was not offered MUST abort the handshake with an "illegal_parameter" alert.

i.e, clients perform checks on legacy_session_id_echo and illegal_parameter, but not legacy_version nor legacy_compression_method. Either (1) wording in Section 4.1.4 should state checks if needed, (2) revise Section 4.1.4 as follows "Upon receipt of a HelloRetryRequest, the client MUST check the legacy_session_id_echo and cipher_suite as specified in Section 4.1.3." or (3) I've misunderstood.

@ekr
Copy link
Contributor

ekr commented Aug 3, 2024

I concur. #1364 fixes this.

@ekr ekr closed this as completed in 0e7198b Aug 5, 2024
ekr added a commit that referenced this issue Aug 5, 2024
Specify checks for legacy_version and legacy_compression_method. Fixes #1355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants