forked from elastic/elasticsearch
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reduce object creation in Rounding class (elastic#38061)
This reduces objects creations in the rounding class (used by aggs) by properly creating the objects only once. Furthermore a few unneeded ZonedDateTime objects were created in order to create other objects out of them. This was changed as well. Running the benchmarks shows a much faster performance for all of the java time based Rounding classes.
- Loading branch information
Showing
2 changed files
with
150 additions
and
73 deletions.
There are no files selected for viewing
97 changes: 97 additions & 0 deletions
97
benchmarks/src/main/java/org/elasticsearch/benchmark/time/RoundingBenchmark.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| /* | ||
| * Licensed to Elasticsearch under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.elasticsearch.benchmark.time; | ||
|
|
||
| import org.elasticsearch.common.Rounding; | ||
| import org.elasticsearch.common.rounding.DateTimeUnit; | ||
| import org.elasticsearch.common.time.DateUtils; | ||
| import org.elasticsearch.common.unit.TimeValue; | ||
| import org.joda.time.DateTimeZone; | ||
| import org.openjdk.jmh.annotations.Benchmark; | ||
| import org.openjdk.jmh.annotations.BenchmarkMode; | ||
| import org.openjdk.jmh.annotations.Fork; | ||
| import org.openjdk.jmh.annotations.Measurement; | ||
| import org.openjdk.jmh.annotations.Mode; | ||
| import org.openjdk.jmh.annotations.OutputTimeUnit; | ||
| import org.openjdk.jmh.annotations.Scope; | ||
| import org.openjdk.jmh.annotations.State; | ||
| import org.openjdk.jmh.annotations.Warmup; | ||
|
|
||
| import java.time.ZoneId; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| @Fork(3) | ||
| @Warmup(iterations = 10) | ||
| @Measurement(iterations = 10) | ||
| @BenchmarkMode(Mode.AverageTime) | ||
| @OutputTimeUnit(TimeUnit.NANOSECONDS) | ||
| @State(Scope.Benchmark) | ||
| @SuppressWarnings("unused") //invoked by benchmarking framework | ||
| public class RoundingBenchmark { | ||
|
|
||
| private final ZoneId zoneId = ZoneId.of("Europe/Amsterdam"); | ||
| private final DateTimeZone timeZone = DateUtils.zoneIdToDateTimeZone(zoneId); | ||
|
|
||
| private final org.elasticsearch.common.rounding.Rounding jodaRounding = | ||
| org.elasticsearch.common.rounding.Rounding.builder(DateTimeUnit.HOUR_OF_DAY).timeZone(timeZone).build(); | ||
| private final Rounding javaRounding = Rounding.builder(Rounding.DateTimeUnit.HOUR_OF_DAY) | ||
| .timeZone(zoneId).build(); | ||
|
|
||
| private final org.elasticsearch.common.rounding.Rounding jodaDayOfMonthRounding = | ||
| org.elasticsearch.common.rounding.Rounding.builder(DateTimeUnit.DAY_OF_MONTH).timeZone(timeZone).build(); | ||
| private final Rounding javaDayOfMonthRounding = Rounding.builder(TimeValue.timeValueMinutes(60)) | ||
| .timeZone(zoneId).build(); | ||
|
|
||
| private final org.elasticsearch.common.rounding.Rounding timeIntervalRoundingJoda = | ||
| org.elasticsearch.common.rounding.Rounding.builder(DateTimeUnit.DAY_OF_MONTH).timeZone(timeZone).build(); | ||
| private final Rounding timeIntervalRoundingJava = Rounding.builder(TimeValue.timeValueMinutes(60)) | ||
| .timeZone(zoneId).build(); | ||
|
|
||
| private final long timestamp = 1548879021354L; | ||
|
|
||
| @Benchmark | ||
| public long timeRoundingDateTimeUnitJoda() { | ||
| return jodaRounding.round(timestamp); | ||
| } | ||
|
|
||
| @Benchmark | ||
| public long timeRoundingDateTimeUnitJava() { | ||
| return javaRounding.round(timestamp); | ||
| } | ||
|
|
||
| @Benchmark | ||
| public long timeRoundingDateTimeUnitDayOfMonthJoda() { | ||
| return jodaDayOfMonthRounding.round(timestamp); | ||
| } | ||
|
|
||
| @Benchmark | ||
| public long timeRoundingDateTimeUnitDayOfMonthJava() { | ||
| return javaDayOfMonthRounding.round(timestamp); | ||
| } | ||
|
|
||
| @Benchmark | ||
| public long timeIntervalRoundingJava() { | ||
| return timeIntervalRoundingJava.round(timestamp); | ||
| } | ||
|
|
||
| @Benchmark | ||
| public long timeIntervalRoundingJoda() { | ||
| return timeIntervalRoundingJoda.round(timestamp); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters