Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client spec: require exiting with non-zero code on missing page #4246

Merged
merged 4 commits into from
Aug 31, 2020
Merged

Client spec: require exiting with non-zero code on missing page #4246

merged 4 commits into from
Aug 31, 2020

Conversation

MasterOdin
Copy link
Collaborator

@MasterOdin MasterOdin commented Aug 3, 2020

This updates the specification to include a recommendation on exiting with a non-zero exit code in addition to showing an error message, which is helpful for scripts and things that may be consuming this tool.


Edit by @sbrl: Fixes #4227

CLIENT-SPECIFICATION.md Outdated Show resolved Hide resolved
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MasterOdin :D

@sbrl
Copy link
Member

sbrl commented Aug 30, 2020

Are we good to merge this?

Copy link
Member

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — thanks for taking this on!

@waldyrious waldyrious changed the title Add recommendation to exiting with non-zero code on missing page Client spec: require exiting with non-zero code on missing page Aug 31, 2020
@waldyrious waldyrious merged commit 87324c6 into tldr-pages:master Aug 31, 2020
@MasterOdin MasterOdin deleted the patch-1 branch January 2, 2021 19:00
@bl-ue bl-ue added the documentation Issues/PRs modifying the documentation. label Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues/PRs modifying the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tldr should not return 0 when a TLDR page is not found
4 participants