This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Added metadata field to lti tool model, visible to admin only (#10) #264
Merged
roujiawang
merged 7 commits into
tl-its-umich-edu:main
from
roujiawang:issue-10-internal_metadata
Sep 8, 2022
Merged
Added metadata field to lti tool model, visible to admin only (#10) #264
roujiawang
merged 7 commits into
tl-its-umich-edu:main
from
roujiawang:issue-10-internal_metadata
Sep 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roujiawang
requested review from
ssciolla,
danie1zhang and
jonespm
and removed request for
danie1zhang
August 3, 2022 13:28
ssciolla
reviewed
Aug 4, 2022
ssciolla
reviewed
Aug 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a functional and seems like it would be useful, at least during the content creation or editing phase for pasting snippets or tracking progress on review, etc. I just wonder if metadata
is the appropriate name. I'd like to hear @jonespm's or @ziegler1960's opinion.
…elpful message about this field's use in admin view
ssciolla
approved these changes
Aug 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! With one approval, you can merge this now. Click "Squash and merge" at the bottom when you're ready.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #10