Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Added metadata field to lti tool model, visible to admin only (#10) #264

Merged

Conversation

roujiawang
Copy link
Contributor

Resolved #10

@roujiawang roujiawang added enhancement New feature or request backend labels Aug 2, 2022
@roujiawang roujiawang marked this pull request as ready for review August 2, 2022 20:35
@roujiawang roujiawang requested review from ssciolla, danie1zhang and jonespm and removed request for danie1zhang August 3, 2022 13:28
Copy link
Contributor

@ssciolla ssciolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a functional and seems like it would be useful, at least during the content creation or editing phase for pasting snippets or tracking progress on review, etc. I just wonder if metadata is the appropriate name. I'd like to hear @jonespm's or @ziegler1960's opinion.

backend/canvas_app_explorer/models.py Outdated Show resolved Hide resolved
…elpful message about this field's use in admin view
Copy link
Contributor

@ssciolla ssciolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! With one approval, you can merge this now. Click "Squash and merge" at the bottom when you're ready.

@roujiawang roujiawang merged commit 364847a into tl-its-umich-edu:main Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a place for admins to store internal metadata (like notes and tool configuration information)
4 participants