Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Some authorization messages shouldn't be logging tokens at the INFO level #267

Closed
jonespm opened this issue Aug 4, 2022 · 2 comments · Fixed by #286
Closed

Some authorization messages shouldn't be logging tokens at the INFO level #267

jonespm opened this issue Aug 4, 2022 · 2 comments · Fixed by #286
Assignees
Labels
backend bug Something isn't working

Comments

@jonespm
Copy link
Member

jonespm commented Aug 4, 2022

I noticed a few log messages at the INFO level. These may be coming from the OAuth package. These are more debug level messages but we could also change the logger to make this package only log WARN as there are many INFO messages from here that seem to be noisy.

[2022-08-02 18:16:23 +0000] [INFO] [canvas.py:69] authorization_code POST response from Canvas is 
[2022-08-02 18:16:21 +0000] [INFO] [oauth.py:73] Redirecting user to https://umich.instructure.com/login/oauth2/auth?
@ssciolla ssciolla added bug Something isn't working backend labels Aug 16, 2022
@jonespm jonespm self-assigned this Aug 22, 2022
@jonespm
Copy link
Member Author

jonespm commented Sep 2, 2022

Will probably fix now that #263 is fixed and the logging block is cleaned up. Guessing to just increase this package to WARN.

@zqian
Copy link
Member

zqian commented Dec 5, 2022

Tested with CAE dev integrated with Canvas test, with ROOT_LOG_LEVEL = INFO:

Those OAuth logging messages are not in log file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants