Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identifier name to styled class #253

Merged
merged 2 commits into from
Aug 11, 2017
Merged

Conversation

emmatown
Copy link
Member

What: Add identifier name to styled class used for nested selectors

Why: Closes #247

How: Use getIdentifierName to get the identifier name and add the name to the class returned by getComponentId

Checklist:

  • Documentation N/A
  • Tests
  • Code complete

This also fully removes the name property stuff

@codecov-io
Copy link

codecov-io commented Aug 11, 2017

Codecov Report

Merging #253 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
- Coverage   90.29%   90.23%   -0.07%     
==========================================
  Files          20       20              
  Lines         969      963       -6     
  Branches      261      260       -1     
==========================================
- Hits          875      869       -6     
  Misses         76       76              
  Partials       18       18
Impacted Files Coverage Δ
test/extract/extract.test.emotion.css 100% <ø> (ø) ⬆️
src/babel.js 97.74% <100%> (ø) ⬆️
src/inline.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a82394...60df56c. Read the comment docs.

@tkh44 tkh44 self-requested a review August 11, 2017 06:03
Copy link
Member

@tkh44 tkh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source

@emmatown emmatown merged commit 19ce8b2 into master Aug 11, 2017
@emmatown emmatown deleted the identifier-name-in-styled-class branch August 11, 2017 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class names generated with getComponentId should have the identifier name in them.
3 participants