Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class names generated with getComponentId should have the identifier name in them. #247

Closed
tkh44 opened this issue Aug 9, 2017 · 0 comments · Fixed by #253
Closed

Class names generated with getComponentId should have the identifier name in them. #247

tkh44 opened this issue Aug 9, 2017 · 0 comments · Fixed by #253
Assignees
@emmatown

Comments

@tkh44
Copy link
Member

tkh44 commented Aug 9, 2017 

const Block = styled('div')`display:block;`

should have a generated class name like css-Block-12345
@tkh44 tkh44 changed the title Class names generated with getComponentId should I have have the identifier name in them. Class names generated with getComponentId should have the identifier name in them. Aug 10, 2017
@emmatown emmatown self-assigned this Aug 11, 2017
emmatown added a commit that referenced this issue Aug 11, 2017
@emmatown
Add identifier name to styled class
acb9965 
Closes #247
@emmatown emmatown mentioned this issue Aug 11, 2017
Merged
3 tasks
emmatown added a commit that referenced this issue Aug 11, 2017
@emmatown
Add identifier name to styled class (#253)
19ce8b2 
* Add identifier name to styled class

Closes #247

* 7.0.13
This was referenced Mar 9, 2020
Open
Open
@Bhanditz Bhanditz mentioned this issue Nov 4, 2022
Open
@Bhanditz Bhanditz mentioned this issue Dec 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emmatown emmatown

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add identifier name to styled class emotion-js/emotion
2 participants
@tkh44 @emmatown