Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partials Underscore Compile #305

Merged
merged 2 commits into from
Mar 19, 2018

Conversation

jaysonpotter
Copy link
Contributor

Made a small quick modification to the underscore support render method to allow the template partials to get compiled allowing data to get passed to those as well.

var user = {username: 'Beetlejuice'};
<%= partials.xanadu(user) %>

Ya dig?

Made a small modification to the underscore support render method to allow the template partials to get compiled allowing data to get passed to those as well. 

var user = {username: 'Beetlejuice'};
<%= partials.xanadu(user) %>
@doowb
Copy link
Collaborator

doowb commented Mar 16, 2018

Thanks!

Will you add a fixture for this in test/fixtures/underscore and include underscore in the partials tests? I'll review this weekend and get it merged.

@doowb doowb self-assigned this Mar 16, 2018
@jaysonpotter
Copy link
Contributor Author

Oh you bet! Happy to and THANK YOU!

Added test fixtures and a test for the added support of underscore
partials.
@doowb doowb merged commit 5480139 into tj:master Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants