-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public Arguments property #2010
Merged
shadowspawn
merged 2 commits into
tj:develop
from
shadowspawn:feature/public-arguments-property
Sep 11, 2023
Merged
Add public Arguments property #2010
shadowspawn
merged 2 commits into
tj:develop
from
shadowspawn:feature/public-arguments-property
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Wee Bit <aweebit64@gmail.com>
abetomo
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Shipped in Commander v11.1.0 |
This was referenced Oct 13, 2023
This was referenced May 26, 2024
This was referenced Jun 6, 2024
This was referenced Jun 19, 2024
This was referenced Jul 16, 2024
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
There is no public property for the command
Argument[]
, like there is withprogram.options
andprogram.commands
.The
Help.visibleArguments()
is not a working alternative since unless the argument have descriptions, there are no visible arguments.See: #1823
Solution
Add
.registeredArguments
, as suggested in #1970Reminder to self: preserve co-author commit comment.
ChangeLog
cmd.registeredArguments
to access the commandArgument
array