Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tsconfig.json to tsconfig.json #1985

Closed
wants to merge 1 commit into from

Conversation

angelaschultz0622
Copy link

Pull Request

Problem

Solution

ChangeLog

@shadowspawn
Copy link
Collaborator

There is a refactor of the type checking open in #1969. I decided to stick with tsconfig.json so more tooling uses it by default.

What are you trying to do in this PR?

(Also: #1960 #1962 #1975)

Copy link
Author

@angelaschultz0622 angelaschultz0622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name change

@angelaschultz0622
Copy link
Author

Rename

@shadowspawn
Copy link
Collaborator

You have made a fork of Commander: https://github.com/tj/commander.js

You have made lots of branches on your fork: https://github.com/angelaschultz0622/commander.js/branches

All fine so far. But you are opening Pull Requests to merge your branches into the upstream repository and not your fork. That is spamming this repository and my email with apparently empty pull requests.

If you are experimenting, you should be making a Pull Request against your own fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants