-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: defining an option which includes no-
makes the option true by default
#1301
Comments
I think the bug is here - Line 26 in 6405325
|
it should be |
Reproduced. I did a bit of digging to see how the code has evolved. Back in Commander v2.3.0, the |
Co-author: snitin315@gmail.com
Fixed in Commander v6.0.0 which has been released: https://github.com/tj/commander.js/releases/tag/v6.0.0 |
Current Behavior -
If we define an option whose name contains
no-
for e.g.module-no-parse
, it makes the optiontrue
by default.Expected Behavior -
It is supposed to do this only for flags with leading
no-
as mentioned in docs. https://github.com/tj/commander.js/#other-option-types-negatable-boolean-and-flagvalueSteps to reproduce -
![Screenshot at 2020-07-16 20-28-38](https://user-images.githubusercontent.com/46647141/87770313-813be300-c83c-11ea-859e-4ad9ac7fc54e.png)
Define an option whose name includes
no-
e.g.module-no-parse
.Check its default value in the parser.
Addition Info
Bug found via webpack/webpack-cli#1679
The text was updated successfully, but these errors were encountered: