Switch to become a ES7 async/await-style generator function wrapper #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanong
changed the title
|
LGTM! |
|
@tj can you add me on npm? |
|
@jonathanong added |
|
Change a lot |
|
Should this be released after node 0.12? How's the |
|
what do you mean? v0.11 already has promises, though it might not be ideal. I think the latest version has an okay implementation. hopefully they'll include the version of node that has generators enabled in v0.12 |
|
ignore me. nodejs/node-v0.x-archive#7714 already landed in 0.11.14. |
|
does this maintain backwards compatibility or no? |
|
nvm, looks like it doesnt. read some of the readme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better version of #134. now it's future-proof with async/await, and i also got 100% coverage!
only issue is that the browser is now required to have a Promise implementation, so we run into the same #149 problem, but i don't think we should bother solving that because if a platform supports generators, it'll support promises as well.
i'll update the examples, readme, and wiki if we decide to merge this. this would be v4
issue bookkeeping: closes #149 closes #143 closes #133 closes #136 closes #131 closes #81