-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update input warning #1870
Commits on Jan 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aacdc82 - Browse repository at this point
Copy the full SHA aacdc82View commit details -
Configuration menu - View commit details
-
Copy full SHA for db20d41 - Browse repository at this point
Copy the full SHA db20d41View commit details -
Apply suggestions from code review
Co-authored-by: tj-actions[bot] <109116665+tj-actions-bot@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c28eedd - Browse repository at this point
Copy the full SHA c28eeddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 375be20 - Browse repository at this point
Copy the full SHA 375be20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79b060d - Browse repository at this point
Copy the full SHA 79b060dView commit details -
refactor: refactor action inputs to use default settings
- Addition of `ACTION_INPUT_DEFAULTS` object in `constant.ts` including default settings. - Made changes in `utils.ts` replacing `actionInputs` references with the newly added `ACTION_INPUT_DEFAULTS`.
Configuration menu - View commit details
-
Copy full SHA for 8a8e4b7 - Browse repository at this point
Copy the full SHA 8a8e4b7View commit details -
refactor: refactor REST API input handling in utils and constants
- Removed imports for the `fs` module and `path` from the `utils.test.ts` file - Deleted the `actionPath` argument from the `warnUnsupportedRESTAPIInputs` function in `utils.test.ts` - All tests related to YAML errors in the action file have been removed from `utils.test.ts` - Removed the `UNSUPPORTED_REST_API_INPUTS` constant from the `constant.ts` file and replaced it with a `Partial` type within the `UNSUPPORTED_REST_API_INPUTS` export - The file `utils.ts` has been updated to reflect the changes in `constant.ts`. It now iterates over `Object.keys(UNSUPPORTED_REST_API_INPUTS)`, substitutes `UNSUPPORTED_REST_API_INPUTS` for `ACTION_INPUT_DEFAULTS`, and uses type casting in condition checking.
Configuration menu - View commit details
-
Copy full SHA for 59d9755 - Browse repository at this point
Copy the full SHA 59d9755View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1839724 - Browse repository at this point
Copy the full SHA 1839724View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2907d5 - Browse repository at this point
Copy the full SHA c2907d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89fe46d - Browse repository at this point
Copy the full SHA 89fe46dView commit details -
refactor: refactor GitHub actions and API handling
- Remove the conditional checking for `GITHUB_ACTION_PATH` before calling `warnUnsupportedRESTAPIInputs` - Change in procedure for getting changed files from the REST API.
Configuration menu - View commit details
-
Copy full SHA for b8d749c - Browse repository at this point
Copy the full SHA b8d749cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f76336 - Browse repository at this point
Copy the full SHA 6f76336View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78bbe66 - Browse repository at this point
Copy the full SHA 78bbe66View commit details
Commits on Jan 18, 2024
-
refactor: refactor key referencing in
warnUnsupportedRESTAPIInputs
……function - Change the way key is referenced in the `warnUnsupportedRESTAPIInputs` function in `utils.ts` to use `snakeCase` only at the point of warning message generation.
Configuration menu - View commit details
-
Copy full SHA for 08316e3 - Browse repository at this point
Copy the full SHA 08316e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 990ef65 - Browse repository at this point
Copy the full SHA 990ef65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16ab734 - Browse repository at this point
Copy the full SHA 16ab734View commit details -
ci: "Refactor testing workflow and improve assertions"
- Remove the `sha` parameter from the `.github/workflows/multi-job-test.yml` file - Add an expectation to check if `coreWarningSpy` is called once in `utils.test.ts`
Configuration menu - View commit details
-
Copy full SHA for 19bdaea - Browse repository at this point
Copy the full SHA 19bdaeaView commit details