-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom source sha #126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackton1
requested changes
Jul 14, 2021
@Kras4ooo Thanks for implementing this fix added some updates that would be required. |
jackton1
approved these changes
Jul 14, 2021
@all-contributors add @Kras4ooo for code and documentation |
I've put up a pull request to add @Kras4ooo! 🎉 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did this PR
I hit the issue when I created PR and when I use:
When we use
github.head_ref
we checkout the current branch. But after that the script getsgithub.sha
but the value of sha is not equal to the PR value, so we have difference between the branch sha and thegithub.sha
. I receive similar error:With this PR we can pass the source sha and now I can pass the correct sha for the source branch and all works well.
Why I use:
export GITHUB_SHA=${{ inputs.sha != '' && inputs.sha || github.sha }}
vsGITHUB_SHA=${{ inputs.sha != '' && inputs.sha || github.sha }}
in env section: When we use env section we pass variable but after that the Github action overrideGITHUB_SHA
and in order to avoid this I just addexport
right before entrypoint execution.