Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Webpack plugin to accept existing processor, and add test. #535

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Update Webpack plugin to accept existing processor, and add test. #535

merged 2 commits into from
Jan 11, 2019

Conversation

kevinkace
Copy link
Contributor

Take 2! 😎

@codecov
Copy link

codecov bot commented Jan 10, 2019 •
edited
Loading

Codecov Report

Merging #535 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          40       40           
  Lines         927      927           
  Branches      139      140    +1     
=======================================
  Hits          919      919           
  Misses          8        8
Impacted Files Coverage Δ
packages/webpack/plugin.js 94.87% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d29447...3529625. Read the comment docs.

tivac
tivac requested changes Jan 11, 2019
View reviewed changes
Copy link
Owner

@tivac tivac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

One small request: would you also update packages/webpack/README.md w/ the new option? Here's the rollup version for reference.

@kevinkace
Copy link
Contributor Author

Will do!

tivac
tivac approved these changes Jan 11, 2019
View reviewed changes
Copy link
Owner

@tivac tivac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻x💯

@tivac tivac merged commit 15f1e15 into tivac:master Jan 11, 2019
@tivac
Copy link
Owner

tivac commented Jan 11, 2019

This is released in @modular-css/webpack@19.2.0. Thanks again @kevinkace!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tivac tivac tivac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinkace @tivac