Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pillow to 10.0.0 and fix text size calculation in text_filter #354

Closed
wants to merge 3 commits into from
Closed

Conversation

irthomasthomas
Copy link

A quick fix for #353

pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@coolapso
Copy link

would be nice to see this merged. But its me or this project feels somewhat abandoned?

@timothycrosley last commit on Github was on March 13 2023.
The last commit on this project dates from April 30.

Pull requests and issues are piling. Hard to tell the direction this is going and quite sad since its probably the best tool out there for streamdeck on linux

@irthomasthomas
Copy link
Author

would be nice to see this merged. But its me or this project feels somewhat abandoned?

@timothycrosley last commit on Github was on March 13 2023. The last commit on this project dates from April 30.

Pull requests and issues are piling. Hard to tell the direction this is going and quite sad since its probably the best tool out there for streamdeck on linux

Agreed. If we don't here back from @timothycrosley then I guess we will have to fork it.

@irthomasthomas
Copy link
Author

would be nice to see this merged. But its me or this project feels somewhat abandoned?

@timothycrosley last commit on Github was on March 13 2023. The last commit on this project dates from April 30.

Pull requests and issues are piling. Hard to tell the direction this is going and quite sad since its probably the best tool out there for streamdeck on linux

I'm actually worried, now. I just checked his Twitter, and his last tweet was a new year's resolution to make one commit every day, but he hasn't made any commits since March. Hopefully, he's just taking a break from online. If not, we will have to fork it. @4s3ti @hugovk @abcminiuser @lhayhurst

@coolapso
Copy link

yeah lets give it some time and hope that he just went offline for a while. but I'd say it might be about time to fork soon.

My knowledge on python is sort of limited.
but, unless someone want's to keep responsibility over it, ill be glad to fork it and maintain at least the PR and release workflow and sync with the maintainer of the Arch AUR package.

@Danie10
Copy link

Danie10 commented Jul 20, 2023

I've sent an e-mail now to Timothy's GMail address asking if he will respond here to let us know.

@Data-007
Copy link

I've sent an e-mail now to Timothy's GMail address asking if he will respond here to let us know.

Would be nice to have some input, especially on plugin system that was proposed but never done,
I think Pieter has some code that's not finished/polished enough.

Frankly it could do with some injection like RedBull thrown in, or some new bodies.

@Danie10
Copy link

Danie10 commented Jul 22, 2023

No response yet to the mail I sent to @timothycrosley 46 hours ago.

@Data-007
Copy link

@Danie10 Frankly I fear that more is need. I emailed you about @dodgyrabbit
Maybe its time to take it on. I do understand that Pieter is very busy.

I would love to see some improvements, #208 being one prominent one im most
interested in I think from what Pieter has typed that he has a ruff working copy.

Plz look over issues tag #208 in issues.
Thanks

@Danie10
Copy link

Danie10 commented Jul 22, 2023

@Data-007 I received no e-mail tho? Yes, I see @dodgyrabbit has two stream deck projects but both updated more than a year ago. It would be great to be able to all move to an agreed fork, and also be able to do an import of what we have already set up if possible (easy migration path).

@Data-007
Copy link

Data-007 commented Jul 22, 2023

Hi @Danie10
I think I got mixed up with who I emailed or not. But I agree in part, I think that it is important to do this right.
To my knowledge it has all-way's been Pieter that's done most of it. It to me does not feel right to just fork and
leave without....

Would be nice to see some improvements, thee #208, plugins, the improvements that everyone wants.

But to be fair anyone can fork it, I think its the best one Ive seen(streamdeck-Linux) so far, their are a few others which I did find but they are behind. Im Just after a decent project(StreamDeck) that will help others.

I have a smattering of python, but I don't know it well. If we hear nothing shortly I would go with a fork.
Who Where When, Some one has to do it and report it. Ile admit I have an OLD fork of it but I think a fresh
one maybe better, Would have to be set up properly.

Your thoughts!??

--
Data

@Data-007
Copy link

@Danie10 @

@Data-007 I received no e-mail tho? Yes, I see @dodgyrabbit has two stream deck projects but both updated more than >a year ago. It would be great to be able to all move to an agreed fork, and also be able to do an import of what we have >already set up if possible (easy migration path).

Ok Im a novice at GitHub however I have forked the Repo, if anyone wants to help/help with setup/submit stuff.
Have a look @Data-007 public repo it's a carbon copy, wort's an all.
Data.

@Danie10
Copy link

Danie10 commented Jul 22, 2023

Thanks @Data-007 but that was also why I did not fork it myself. I'm not really experienced at managing multiple commits and branches on Github. It requires the active participation by the key guys who would do the coding (those so far submitting workflow approvals here), and maybe one of them wants to take the lead via their project. But let's hear what they have to say. I'm hoping that we all move to one new fork.

@coolapso
Copy link

coolapso commented Jul 22, 2023

ok ... sorry ... but the way this is going worries me ...

first ... let's not take rushed steps.

@Data-007

Ok Im a novice at GitHub however I have forked the Repo, if anyone wants to help/help with setup/submit stuff.

this doesn't bring me much confidence ... If we are taking over a project because the original owner vanished, then in a project like this needs someone that is more comfortable around, but on the other hand,I am perfectly fine with that (no one was born with all the knowledge and swimming with the sharks is a perfect way to do so!) as long as there are multiple maintainers . to avoid again the BUS Factor and open comms between all of them.

Whoever is in charge also should account that there are probably some other projects / packages relying on this, I can count at least the Arch AUR package manager.

I suggest to get a list of volunteers to Fork and maintain the project, then find a place where we all can talk and agree with the path forward and then take action.

Even tho I know some python I have very little experience with it, would need for sure much more help in code related tasks. but I am very comfortable with everything else and I am ok into taking care of almost everything related with the project, from seting up the repo, to testing and release pipelines.

This being said, regardless of where this is forked into, I am here to help with anything. I have been wanting to contribute to this project in a while so the opportunity presented itself!

@coolapso
Copy link

Ok ... let's take this discussion here: #357

as we are driving really away from the topic of this pull request.

@coolapso
Copy link

@irthomasthomas could you pls make this PR in the new repository?

https://github.com/streamdeck-linux-gui/streamdeck-linux-gui

if not asking too much please try to follow the new contribution rules to make things smoother :)

Hopefully the AUR package will also piggy back on this and we will get it there :)

thanks a lot.

@irthomasthomas
Copy link
Author

Thanks! I'll get on it, now.

@irthomasthomas irthomasthomas closed this by deleting the head repository Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants