Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim down to SnoopCompile and SnoopCompileCore #127

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Conversation

timholy
Copy link
Owner

@timholy timholy commented Aug 3, 2020

This will be version 2.0 of SnoopCompile. It excises the bot, which should move to a separate repository. It also merges SnoopCompileAnalysis back into SnoopCompile itself.

Closes #118
Closes #121
Closes #122
Closes #77
Closes #99
Closes #100
Closes #115

This will be version 2.0 of SnoopCompile.
It excises the bot, which should move to a separate repository.
It also merges SnoopCompileAnalysis back into SnoopCompile itself.
@aminya
Copy link
Contributor

aminya commented Aug 4, 2020

Thanks for this. I will move the repository to my account later this week.

I want to vote against merging Analysis and Core modules. The analysis module compiles parts of code that can make the snooping result inaccurate in some cases. For example, when you want to use SnoopCompile for snooping Pkg or some other core library. These deps can bring a lot of compiled code which decreases the accuracy of snooping for such core packages:

Cthulhu 
OrderedCollections 

@timholy
Copy link
Owner Author

timholy commented Aug 4, 2020

Core and "Analysis" are still separate. What I did was basically take Analysis's code and put it in SnoopCompile itself. So you can do all the snooping with SnoopCompileCore, and then just say using SnoopCompile. That gives you what you used to get with SnoopCompileAnalysis.

@aminya
Copy link
Contributor

aminya commented Aug 4, 2020

Core and "Analysis" are still separate. What I did was basically take Analysis's code and put it in SnoopCompile itself. So you can do all the snooping with SnoopCompileCore, and then just say using SnoopCompile. That gives you want you used to get with SnoopCompileAnalysis.

Oh, I see. That would work. 👍

@timholy timholy merged commit f75e1b3 into master Aug 10, 2020
@timholy timholy deleted the teh/version2 branch August 10, 2020 11:36
@aminya
Copy link
Contributor

aminya commented Aug 11, 2020

@timholy I want to move SnoopCompileBot to my account, but I have a question. Should I start a fresh git repository or there is a way to keep the git history for certain files?

Edit: the following did the job

git filter-branch -f --tree-filter "rm -rf ./Project.toml ./LICENSE.md ./NEWS.md ./README.md ./SnoopCompileAnalysis ./SnoopCompileCore ./src ./examples ./test ./utils ./docs/* ./docs/src/index.md ./docs/src/reference.md ./docs/src/snoopc.md ./docs/src/snoopi.md ./docs/src/snoopr.md ./docs/src/userimg.md" --prune-empty HEAD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants