Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ARM32 tests on travis #1019

Merged
merged 3 commits into from
Jun 10, 2019
Merged

Add ARM32 tests on travis #1019

merged 3 commits into from
Jun 10, 2019

Conversation

Ngalstyan4
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 27, 2019

Codecov Report

Merging #1019 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
- Coverage   91.68%   91.56%   -0.13%     
==========================================
  Files          91      104      +13     
  Lines       10491    11011     +520     
==========================================
+ Hits         9619    10082     +463     
- Misses        872      929      +57
Impacted Files Coverage Δ
src/chunk_dispatch_state.c 91.93% <0%> (-1.13%) ⬇️
src/process_utility.c 94.22% <0%> (-0.23%) ⬇️
src/hypertable.c 90.34% <0%> (-0.2%) ⬇️
src/copy.c 87.44% <0%> (-0.06%) ⬇️
src/chunk_insert_state.c 97.14% <0%> (-0.04%) ⬇️
src/constraint_aware_append.c 95.74% <0%> (-0.03%) ⬇️
src/chunk_index.c 91.2% <0%> (-0.03%) ⬇️
src/bgw/job.c 95.72% <0%> (-0.03%) ⬇️
src/plan_expand_hypertable.c 98.52% <0%> (-0.02%) ⬇️
src/plan_ordered_append.c 100% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf67ddd...8e7788f. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 27, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@70a02b5). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1019   +/-   ##
=========================================
  Coverage          ?   91.91%           
=========================================
  Files             ?      111           
  Lines             ?    14351           
  Branches          ?        0           
=========================================
  Hits              ?    13191           
  Misses            ?     1160           
  Partials          ?        0
Impacted Files Coverage Δ
src/bgw/timer.c 82.14% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a02b5...b9ef2b7. Read the comment docs.

@svenklemm
Copy link
Member

I do not think we want to run this on PRs at 14 minutes runtime. I would also prefer if this runs PG10 or 9.6 and 10 when moved to cron

mfreed
mfreed reviewed Jan 27, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
mfreed
mfreed previously requested changes Jan 27, 2019
View reviewed changes
Copy link
Member

@mfreed mfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move docker hub from personal to timescale.

@Ngalstyan4
Copy link
Contributor Author

I do not think we want to run this on PRs at 14 minutes runtime. I would also prefer if this runs PG10 or 9.6 and 10 when moved to cron

This will be converted to only run from pre-release brunch. I am still working on it that is why as of now I run it from all PRs.
I was going to discuss PG10 and PG11 support with you and others soon.
Those require more work as PG10 is not yet officially supported for RaspberryPi and so there are no precompiled binaries.

@cevian cevian added the testing label Feb 14, 2019
@Ngalstyan4 Ngalstyan4 force-pushed the travis_arm_testing branch 20 times, most recently from 40e494c to 1d3c2a0 Compare February 23, 2019 01:06
@Ngalstyan4 Ngalstyan4 force-pushed the travis_arm_testing branch 2 times, most recently from 26cca55 to 2b17ab0 Compare April 5, 2019 19:54
@Ngalstyan4 Ngalstyan4 force-pushed the travis_arm_testing branch 10 times, most recently from 08f5447 to 4be2719 Compare May 27, 2019 16:19
Ngalstyan4
Ngalstyan4 commented May 27, 2019
View reviewed changes
.travis.yml Outdated
- docker exec -u postgres -it docker_arm_emulator cat /build/tsl/test/log/initdb.log /timescaledb/build/test/regression.diffs /timescaledb/build/tsl/test/regression.diffs /timescaledb/build/test/isolation/regression.diffs /timescaledb/build/test/pgtest/regression.diffs && echo $LANG $LC_ALL
script:
# allow 50 mins to run
- travis_wait 50 docker exec -u postgres docker_arm_emulator /bin/bash -c "cd /build && make installcheck IGNORES='multi_transaction_indexing sql_query_results_unoptimized sql_query_results_x_diff chunk_utils bgw_db_scheduler continuous_aggs_insert plan_expand_hypertable-9.6 sql_query_results_unoptimized-9.6 sql_query_results_x_diff-9.6 plan_hashagg-9.6'"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis_wait is not tty so docker exec -it will not work which means one cannot see continuous output in travis from this command. A workaround is described here but this approach would mean tests are marked as completed exactly after the specified wait time passes and not when the testing finishes

gayyappan
gayyappan requested changes May 29, 2019
View reviewed changes
src/bgw/timer.c Outdated Show resolved Hide resolved
@Ngalstyan4 Ngalstyan4 force-pushed the travis_arm_testing branch 5 times, most recently from 24cb1cc to 1a234b9 Compare May 31, 2019 18:38
@Ngalstyan4
Fix long-related type issues for ARM CPUs
1bbf6ca 
1. %ld interpolates 32bit numeric values on ARM processors and %lld is
needed to successfully parse int64 types on arm.
2. Postgres TimestampDifference function expects long* for the referene
type of time length but we internally keep int64 for arm and x86
interoperability. The change makes the type cast explicit to suppress a
compile time warning.
@Ngalstyan4
Refactor IGNORES to run tests and ignore result
d19cb7b 
Currently make installcheck IGNORES=... skips ignored tests.
This commit changes IGNORE functionality to mean "run tests but ignore
the result if the test fails" which is what ignore refers to in
pg_regress framework terminology.
The change was necessary to allow running ARM regression tests on
travis and account for known failure issues.
The commit also adds a make installcheck SKIPS=... argument that
replicates the functionality previously refered as IGNORES.
@Ngalstyan4
Add ARM32 testing on Travis
b9ef2b7
@cevian cevian merged commit b860a87 into timescale:master Jun 10, 2019
@cevian cevian added this to the 1.3.2 milestone Jun 21, 2019
@cevian cevian added the bug label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cevian cevian cevian approved these changes

@gayyappan gayyappan gayyappan approved these changes

@mfreed mfreed mfreed left review comments

Assignees
No one assigned
Labels
bug testing
Projects
None yet
Milestone
1.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@Ngalstyan4 @svenklemm @cevian @mfreed @gayyappan