Skip to content

Commit

Permalink
Fix module version, switch to ncc
Browse files Browse the repository at this point in the history
Having node_modules in the repo is problematic. For one thing,
dependabot updates dependencies in package.json, but the old versions of
modules are still there in node_modules.

To fix this, let's switch away from having node_modules in the repo to
using ncc, as they recommend in [1] and [2].

Fix package version in package.json while we're at it.

This commit is mostly auto-generated, the only manual edited files are
package.json and .gitignore. Here is the workflow (using npm 8.9.12):

        $EDITOR package.json
        $EDITOR .gitignore
        git add .gitignore
        git rm -rf node_modules
        rm package-lock.json
        npm i
	npm i @actions/core # bump actions/core version
        git add dist
        git commit

NOTE that this also upgrades @actions/core to the latest 1.x release
(which is 1.10.x at the moment), which probably fixes the issue of GHA
warning about the use of deprecated set-output command. This happens
because ^1.0.9 means "latest 1.x" in npm.

[1] https://github.com/actions/javascript-action/tree/main
[2] https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
  • Loading branch information
kolyshkin committed Aug 31, 2023
1 parent 3efc138 commit 69c9f2f
Show file tree
Hide file tree
Showing 546 changed files with 32,108 additions and 212,321 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
node_modules/
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ outputs:
description: 'commits in pr'
runs:
using: 'node16'
main: 'index.js'
main: 'dist/index.js'
Loading

0 comments on commit 69c9f2f

Please sign in to comment.