Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed increment signedness #8

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Fixed increment signedness #8

merged 2 commits into from
Jun 2, 2022

Conversation

feliwir
Copy link
Contributor

@feliwir feliwir commented May 27, 2022

Closes #6

@tilkinsc
Copy link
Owner

tilkinsc commented May 27, 2022 •
edited
Loading

If you want to take this a step further, please convert the ints to longs. This library will fail when sizeof(int) == 16

@feliwir
Copy link
Contributor Author

feliwir commented May 30, 2022

I was going for int since the valid_window can only be specified as int aswell. Should i change that parameter type aswell?

@tilkinsc
Copy link
Owner

Yeah of course. Converting to longs will ensure at least 32 bits are available which is what we intend.

@feliwir
Copy link
Contributor Author

feliwir commented May 31, 2022

Switched all signatures to long

@tilkinsc tilkinsc merged commit 454df2a into tilkinsc:master Jun 2, 2022
@tilkinsc
Copy link
Owner

tilkinsc commented Jun 2, 2022

Good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verification bug: Signed integer is casted to unsigned
2 participants
@feliwir @tilkinsc