-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL search/query params dropped before routing #53
Comments
More info: Even if I hack the FB server to use req.url (instead of req.path) then this transition abort() in the underlying router lib forces an HTTP Status 500 To recreate: |
Thanks, I'll look into this. |
I can confirm this bug. Anything I can do to help fix it? |
the transition bug should be fixed on canary, but fastboot needs to be updated to consume the new API; I'll send a PR this weekend! |
this is great news (!) - any updates? |
@chancancode Any update on this? |
If I am reading myself correctly, it should already be fixed now? |
I see. I was referring to the "redirect bug", which is indeed fixed in ember now. I think the line @victor-stone was pointing to (https://github.com/ember-fastboot/ember-fastboot-server/blob/5b89456cee90d10785978e2736742a2f1ce7fda7/lib/server.js#L69) still needs to be changed to use |
This commit fixes a bug where query params were inadvertently dropped from the incoming request when routing in Ember. See ember-fastboot/ember-cli-fastboot#53
When hitting the server with an url with query params this line drops the search part of the url and it is never picked up because the Location is forced to 'none' here in Ember
The text was updated successfully, but these errors were encountered: