Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL search/query params dropped before routing #53

Closed
victor-stone opened this issue Jul 31, 2015 · 8 comments
Closed

URL search/query params dropped before routing #53

victor-stone opened this issue Jul 31, 2015 · 8 comments
Labels
Milestone

Comments

@victor-stone
Copy link

When hitting the server with an url with query params this line drops the search part of the url and it is never picked up because the Location is forced to 'none' here in Ember

@victor-stone
Copy link
Author

More info: Even if I hack the FB server to use req.url (instead of req.path) then this transition abort() in the underlying router lib forces an HTTP Status 500

To recreate:

curl http://localhost:3000/somepath?foo=bar

@tomdale tomdale added this to the FastBoot 1.0 milestone Aug 13, 2015
@tomdale
Copy link
Contributor

tomdale commented Aug 13, 2015

Thanks, I'll look into this.

@tomdale tomdale added the bug label Aug 13, 2015
@scottmessinger
Copy link

I can confirm this bug. Anything I can do to help fix it?

@chancancode
Copy link
Contributor

the transition bug should be fixed on canary, but fastboot needs to be updated to consume the new API; I'll send a PR this weekend!

@victor-stone
Copy link
Author

this is great news (!) - any updates?

@tomdale
Copy link
Contributor

tomdale commented Jan 27, 2016

@chancancode Any update on this?

@tomdale tomdale mentioned this issue Jan 27, 2016
38 tasks
@chancancode
Copy link
Contributor

If I am reading myself correctly, it should already be fixed now?

@chancancode
Copy link
Contributor

I see. I was referring to the "redirect bug", which is indeed fixed in ember now. I think the line @victor-stone was pointing to (https://github.com/ember-fastboot/ember-fastboot-server/blob/5b89456cee90d10785978e2736742a2f1ce7fda7/lib/server.js#L69) still needs to be changed to use req.url?

tomdale added a commit to ember-fastboot/fastboot that referenced this issue Feb 24, 2016
This commit fixes a bug where query params were inadvertently dropped
from the incoming request when routing in Ember.

See ember-fastboot/ember-cli-fastboot#53
@tomdale tomdale closed this as completed Feb 24, 2016
xg-wang pushed a commit to xg-wang/ember-cli-fastboot that referenced this issue Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants