-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Road to 1.0 #98
Comments
What about appending requested host to absolute paths in ajax requests |
@danmcclain Added #101 to track that. |
How about being able to control over the |
@taveras It's just an Express middleware, so you can add your own handling for arbitrary endpoints. We should try not to let FastBoot turn into a generic HTTP server. |
Per this week's meeting:
|
I also started working on #99 😃 |
If you're interested in helping out, join us in #fastboot in the Ember community Slack. |
it would also be nice at first to have cache headers in the response ember fastboot --cache-headers 15000 before we have better access to headers |
@sebyx07 It's just an Express middleware, you can add whatever headers you want. |
@tomdale what about "hydrating" or making the fastboot app into a normal emberApp after everything is loaded? |
@MiguelMadero I think that hydrating is blocked until Glimmer 2.0 lands, I'll let someone else confirm |
@MiguelMadero @danmcclain Confirmed |
Thanks for clarifying. |
@tomdale Your latest PR achieves this, right? |
@danmcclain Confirm, good catch! |
Wow - when this is finished, Ember will really be able to DoItAll™️! |
@coladarci - I think it's a safe bet - while fastboot doesn't technically 'rehydrate', it does 'redraw' the application once the browser JS payload hits. It kinda clicks into place. Works really well for the most part 👍 |
Yeah I noticed that, which is great. That said, that means for ~1.5s the actions on the page don't do anything, which is a bit of a blocker for my application :) I'd love to know where to follow the Glimmer 2.0 progress so I can get a rough idea of the blockers and how actively they are being addressed. We'll probably use ember for the new project w/out fastboot but checking it along the way to make sure there are no surprises, then hope we can flip it on before the launch.. I was thinking about a hybrid model where I remove a body class w/ the booted ember app so I can sort of gray out the body until the app is fully loaded; will give the end user immediate feedback and excitement but not render a bunch of busted actions for an awkward few seconds. |
@coladarci Yeah, one thing I'd like to do is automatically add an |
@tomdale So 'hydrating' feature will come with Fastboot 1.0 and Ember 2.7? |
@Cryrivers I suspect it will not be in by FastBoot 1.0, but it's largely gated on Glimmer 2 work. |
@tomdale Am I right in thinking, according to the checklist above, that fastboot is essentially code ready, but needs the associated docs, website, watch, etc, sorting out? |
@oligriffiths Yes, we are very close. The last thing gating a 1.0 release is some performance improvements to the build process. After a lot of core team discussion, people were hesitant about the almost-doubling of build times that installing FastBoot adds to the boot process. @stefanpenner had some great ideas for how we can avoid the extra cost, and I'm hopeful we can get those implemented soon. They will also clean up some of the monkeypatches to Ember CLI internals we have to do at the moment, and should address other usability concerns like #246. |
related: #264 (comment) |
@tomdale Here is an RFC that Stef and I worked on for fixing the fastboot builds. I would prefer to hold up 1.0 release until this is fixed since this a fully backward incompatible change to current fastboot ergonomics. If we don't hold, we will need to jump to Fastboot 2.0 and the experience may not be good. I will be working 100% of my time on that RFC and some other fastboot OSS stuff so I can get this out soon enough. |
Could we get an update on what is still blocking a 1.0 release? I guess #356 is the major blocker here, which is hopefully landing soon, anything else that is not listed in the above to do list? From that list, I think several items have not been updated yet...
Those things seem to have been addressed already, at least in some form. Anything missing there? Can help if needed...
This can be dropped, right? |
there is one more item: fixing this issue #264 . There is a solution to address this and @leitsubomi is going to look at implementing it. |
I'm curious, is there a security evaluation/penetration testing planned for fastboot v1? Has anyone attempted to break it? I'm very excited about fastboot, just as a user I'm concerned about understanding the security implications of moving from a purely static-file serving production environment (which is relatively easy to serve and secure) to one where user requests will interact with a full dynamic server environment with node + middleware, which of course comes with a completely different security footprint. |
Any word on whether rehydration will make it into 1.0, now that Glimmer 2.0 is out? |
#360 supersedes this issue, closing this as it is no longer up to date. Rehydration is not currently a 1.0 blocker, but that doesn't prevent it from landing during the 1.0 series |
@danmcclain I haven't been able to find any information with how ember + fastboot deals with rehydration. Does the app just rerender from scratch in the background and replace the existing dom? |
@citizenconn Rehydration has yet to be implemented, so it has to rerender the app from scratch (or some from the shoebox) then replace the dom |
This is a quest issue tracking the features and bug fixes needed to consider FastBoot ready for mass consumption. Expect this list to grow over time. All discussion and details should be broken out into separate issues/PRs; this issue is just for coordinating and tracking work.
Release Plan
Dockerized FastBoot serveroutputPaths
Production Debugging, Monitoring & Best Practiceswatch
or revert feature for 1.0 releaserequest
andresponse
properties on the FastBoot servicedeferRendering
APIfastboot
fastboot-express-middleware
fastboot-app-server
ember-cli-fastboot
fastboot
fastboot-express-middleware
fastboot-app-server
ember-cli-fastboot
Nice to Have
Please chime in with anything I've missed.
The text was updated successfully, but these errors were encountered: