Health check for stores #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,7 +128,7 @@ func (cb *capacityBalancer) ScoreType() scoreType { | |||
| // selectBalanceRegion tries to select a store leader region to do balance and returns true, but if we cannot find any, | |||
| // we try to find a store follower region and returns false. | |||
| func (cb *capacityBalancer) selectBalanceRegion(cluster *clusterInfo, stores []*storeInfo) (*metapb.Region, *metapb.Peer, *metapb.Peer, bool) { | |||
| store := selectFromStore(stores, cluster.getUnknownStores(), cb.filters, cb.st) | |||
| store := selectFromStore(stores, nil, cb.filters, cb.st) | |||
There was a problem hiding this comment.
Unknown stores will be filtered out in stateFilter, no need to maintain another unknown stores map now.
There was a problem hiding this comment.
so need to remove this arg?
There was a problem hiding this comment.
Some places still need this arg, we may remove it after we do some refactor, but not in this PR.
huachaohuang
force-pushed
the
huachaohuang/health-check-store
branch
from
17a69d8
to
5f86b01
Compare
| @@ -187,6 +187,10 @@ type BalanceConfig struct { | |||
|
|
|||
| // MaxTransferWaitCount is the max heartbeat count to wait leader transfer to finish. | |||
| MaxTransferWaitCount uint64 `toml:"max-transfer-wait-count" json:"max-transfer-wait-count"` | |||
|
|
|||
| // MaxStoreDownInterval is the max interval (in seconds) | |||
There was a problem hiding this comment.
@queenypingcap please help to check comments.
Check unknown stores in `stateFilter` instead of maintaining an unknown stores map.
huachaohuang
force-pushed
the
huachaohuang/health-check-store
branch
from
208d4f7
to
9302f40
Compare
| @@ -49,6 +49,7 @@ var ( | |||
| maxBalanceRetryPerLoop = flag.Uint64("max-balance-retry-per-loop", 10, "the max retry count to balance in a balance schedule") | |||
| maxBalanceCountPerLoop = flag.Uint64("max-balance-count-per-loop", 3, "the max region count to balance in a balance schedule") | |||
| maxTransferWaitCount = flag.Uint64("max-transfer-wait-count", 3, "the max heartbeat count to wait leader transfer to finish") | |||
| maxStoreDownDuration = flag.Uint64("max-store-down-duration", 60, "the max duration a store without heartbeat will be considered to be down") | |||
There was a problem hiding this comment.
@queenypingcap please review the explanation.
|
LGTM |
|
LGTM |
1 similar comment
|
LGTM |
rleungx
pushed a commit
to rleungx/pd
that referenced
this pull request
Dec 1, 2023
Signed-off-by: guo-shaoge <shaoge1994@163.com>
rleungx
pushed a commit
to rleungx/pd
that referenced
this pull request
Dec 1, 2023
rleungx
pushed a commit
to rleungx/pd
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out unknown and down stores from balance.