Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix issue with new PHP CS Fixer #152

Merged
merged 9 commits into from
Jun 24, 2024

Conversation

driftingly
Copy link
Member

@driftingly driftingly commented Jun 20, 2024

This PR fixes an issue with a recent PHP CS Fixer update.
I believe the issue is caused by 3.59.3.

PHP Fatal error:  Class App\Fixer\ClassNotation\CustomOrderedClassElementsFixer contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PhpCsFixer\Fixer\ConfigurableFixerInterface::getConfigurationDefinition) in /app/laravel/vendor/tightenco/duster/app/Fixer/ClassNotation/CustomOrderedClassElementsFixer.php on line 42

Fatal error: Class App\Fixer\ClassNotation\CustomOrderedClassElementsFixer contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PhpCsFixer\Fixer\ConfigurableFixerInterface::getConfigurationDefinition) in /app/laravel/vendor/tightenco/duster/app/Fixer/ClassNotation/CustomOrderedClassElementsFixer.php on line 42

Additionally, I'm including the composer dev lock file to be used within GitHub actions to fix an issue with installing the latest version of Pest. The action used to install the production dependencies then requires Pest and Larastan. This was failing with a recent release of Pest. Now, we are using the same version installed when developing.

Related: #151

Using composer dev in GH actions test, need control over what gets installed.
@driftingly driftingly force-pushed the drift/update-custom-order-class branch from cf6c0b7 to c4195fd Compare June 20, 2024 19:21
@driftingly driftingly marked this pull request as ready for review June 20, 2024 22:20
@driftingly driftingly changed the title Fix issue with new PHP CS Fixer [3.x] Fix issue with new PHP CS Fixer Jun 20, 2024
@driftingly driftingly merged commit 0128c2e into 3.x Jun 24, 2024
4 checks passed
@driftingly driftingly deleted the drift/update-custom-order-class branch June 24, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant