Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disuse deprecated function rosidl_target_interfaces() in humble #4

Conversation

v-sugahara7993-esol
Copy link
Contributor

Description

https://docs.ros.org/en/foxy/Releases/Release-Humble-Hawksbill.html#rosidl-cmake
Humbleではrosidl_target_interfaces()が非推奨となったので、ros2/demos#529 を参考に修正します。

Related Links

https://tier4.atlassian.net/browse/AEAP-487

Tests performed

colconにより、dio_ros_driverのパッケージがビルドできることを確認。

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: v-sugahara7993-esol <v-sugahara7993@esol.co.jp>
Copy link

@m-iwashita-esol m-iwashita-esol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptionにある用例の通り修正されている事を確認しました

Copy link

@h-ohta h-ohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@h-ohta h-ohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta merged commit f363474 into tier4:develop/ros2 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants