Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dummy_perception_publisher): use rosidl_get_typesupport_target instead of rosidl_target_interfaces #516

Conversation

v-nojiri7841-esol
Copy link

Description

https://docs.ros.org/en/humble/Releases/Release-Humble-Hawksbill.html#rosidl-cmake
Humbleではrosidl_target_interfaces()が非推奨となったので、ros2/demos#529 を参考に修正します。

Related Links: https://tier4.atlassian.net/browse/AEAP-550

Tests performed

colconでdummy_perception_publisherをビルドし、Error/Warningが出力されないこと。

Note: 修正前は次のWarningが出力される。

CMake Deprecation Warning at /opt/ros/humble/share/rosidl_cmake/cmake/rosidl_target_interfaces.cmake:32 (message):
  Use rosidl_get_typesupport_target() and target_link_libraries() instead of
  rosidl_target_interfaces()
Call Stack (most recent call first):
  CMakeLists.txt:68 (rosidl_target_interfaces)

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…stead of rosidl_target_interfaces

Signed-off-by: v-nojiri7841-esol <v-nojiri7841@esol.co.jp>
@v-nojiri7841-esol v-nojiri7841-esol self-assigned this May 24, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.3.16@f70128b). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.3.16    #516   +/-   ##
==============================================
  Coverage                ?   5.75%           
==============================================
  Files                   ?      16           
  Lines                   ?     695           
  Branches                ?      32           
==============================================
  Hits                    ?      40           
  Misses                  ?     634           
  Partials                ?      21           
Flag Coverage Δ
differential 5.75% <0.00%> (?)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@h-ohta
Copy link

h-ohta commented May 24, 2023

本家では以下で同様の修正が実施されている
autowarefoundation#761

@h-ohta h-ohta merged commit afe5edb into beta/v0.3.16 May 24, 2023
@h-ohta h-ohta deleted the fix/dummy_perception_pub_use_rosidl_get_typesupport_target branch May 24, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants